[18.0] Migrate sync and partner_telegram#497
Open
lieblinger wants to merge 9 commits intoitpp-labs:17.0from
Open
[18.0] Migrate sync and partner_telegram#497lieblinger wants to merge 9 commits intoitpp-labs:17.0from
lieblinger wants to merge 9 commits intoitpp-labs:17.0from
Conversation
Add missing opcodes that were present in Odoo core but not in the sync_addons fork of safe_eval.py: - _CONST_OPCODES: RETURN_CONST (3.12), TO_BOOL (3.13) - _EXPR_OPCODES: BINARY_SLICE (3.11) - _SAFE_OPCODES: END_FOR, LOAD_FAST_AND_CLEAR, LOAD_FAST_CHECK, POP_JUMP_IF_NOT_NONE, POP_JUMP_IF_NONE, CALL_INTRINSIC_1, STORE_SLICE (3.12), CALL_KW, LOAD_FAST_LOAD_FAST, STORE_FAST_STORE_FAST, STORE_FAST_LOAD_FAST, CONVERT_VALUE, FORMAT_SIMPLE, FORMAT_WITH_SPEC, SET_FUNCTION_ATTRIBUTE (3.13) Also fix _UNSAFE_ATTRIBUTES: "g_yieldfrom" was missing the 'i' and trailing comma, causing silent string concatenation with "cr_await".
Odoo 18's _compute_trigger depends on model_id and resets trigger to False. After creating/updating a sync.trigger.automation record, the trigger value from the task YAML header must be re-applied explicitly.
The previous fix checked record.trigger in the compute method, but the ORM invalidates the field cache before calling compute. In multi-worker production environments, cache invalidation signals between workers trigger recomputation where record.trigger returns False (the default) instead of the stored DB value, causing a NOT NULL constraint violation. Read directly from the database to preserve existing trigger values.
No longer needed — the _compute_trigger override now reads directly from the database, so the trigger value is preserved correctly during recomputation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.