Skip to content

Conversation

Copy link

Copilot AI commented Dec 2, 2025

Users installing the app expect Rich Presence to work immediately after connecting Discord. The current default of false requires an extra manual step.

Changes

  • Set userEnabledRPC default to true in ContentView.swift
  • Added auto-start logic in updateTrackedDiscordState() to automatically initiate RPC when Discord authentication completes and becomes ready
  • Extracted common RPC start/stop logic into startRPCServices() and stopRPCServices() methods for consistency
// Before
@State private var userEnabledRPC = false

// After
@State private var userEnabledRPC = true

When Discord authentication completes:

  • RPC services are automatically started if the toggle is enabled (default)
  • If music is playing, Discord presence is updated immediately

Users can still disable the toggle if desired.

Original prompt

This section details on the original issue you should resolve

<issue_title>feat(iOS): Setting/toggle to enable "Show RPC" turned on default</issue_title>
<issue_description>A setting or just on default, the "show rpc" toggle should be turned on default. And let's be honest, why else would people install the app? It's just a extra step.</issue_description>

Comments on the Issue (you are @copilot in this section)

@thehairy It's also a battery drainer having the app constantly in the background. #36 would be a possible solution.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Dec 2, 2025
…on by default

Co-authored-by: thehairy <71461991+thehairy@users.noreply.github.com>
Copilot AI changed the title [WIP] Set default to enable 'Show RPC' toggle feat(iOS): Enable Rich Presence toggle on by default Dec 2, 2025
Copilot AI requested a review from thehairy December 2, 2025 13:43
Copy link
Member

@thehairy thehairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this won't work like this.
We can't just set it to true, since we also need to check if the discord auth is complete and then also need to initiate the actual RPC, but you know, by default.

Copilot AI and others added 2 commits December 2, 2025 18:41
…d by default

Co-authored-by: thehairy <71461991+thehairy@users.noreply.github.com>
…code duplication

Co-authored-by: thehairy <71461991+thehairy@users.noreply.github.com>
Copy link
Author

Copilot AI commented Dec 2, 2025

I suppose this won't work like this.
We can't just set it to true, since we also need to check if the discord auth is complete and then also need to initiate the actual RPC, but you know, by default.

Good catch! I've updated the implementation in b363bb0. The changes now:

  1. Set userEnabledRPC = true as default
  2. Added auto-start logic in updateTrackedDiscordState() that detects when Discord becomes ready and automatically calls startRPCServices() if userEnabledRPC is enabled
  3. Extracted common start/stop logic into startRPCServices() and stopRPCServices() methods for consistency

This ensures RPC is properly initiated when Discord auth completes, not just on the toggle change event.

Copilot AI requested a review from thehairy December 2, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(iOS): Setting/toggle to enable "Show RPC" turned on default

2 participants