Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #68 +/- ##
============================================
+ Coverage 0.57% 3.70% +3.13%
- Complexity 1205 1251 +46
============================================
Files 156 162 +6
Lines 4362 4448 +86
============================================
+ Hits 25 165 +140
+ Misses 4337 4283 -54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rimi-itk
force-pushed
the
feature/5110-require-event-organizer
branch
2 times, most recently
from
4f8f753 to
619a553
Compare
rimi-itk
force-pushed
the
feature/5110-require-event-organizer
branch
from
619a553 to
92edb10
Compare
rimi-itk
changed the title
turegjorup
reviewed
Aug 14, 2025
| ->where(':user MEMBER OF o.users') | ||
| ->setParameter('user', $this->getUser()) | ||
| ); | ||
| $organization = AssociationField::new('organization') |
Contributor
There was a problem hiding this comment.
A few notes:
- I think the original if/else construct has better readability but that is highly subjective
$organizationFieldwould better signal what is assigned to the vaiable
As for the actual business logic, the intent was:
organizeris ALWAYS requirededitorandadminusers can set organizer from all available organizers.organization-editor/admincan only select form organizations they belong to (they should ALWAYS belong to at least one organization, but I don't think this is enforced)
One further possible improvement (as stated in the linked ticket) would be for organization-editor/admin users that only belong to one organization. If we could set that organization as default value, and disable the field.
| $organization | ||
| ->setFormTypeOption('choices', $userOrganizations) | ||
| // Make sure that the user is not forced to make a choice if none exists. | ||
| ->setRequired($userOrganizations->count() > 0); |
Contributor
There was a problem hiding this comment.
Choice should exist, so better to throw an exception.
# Conflicts: # CHANGELOG.md # README.md # config/packages/security.yaml
…nizations Add EasyAdmin filters to UserCrudController for organizations, has/no organization, roles (JSON-aware), and email. Add console command app:user:list-without-organization to list non-editor users with no organization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instead of displaying a summary of all validation errors, scroll to and focus the first invalid field. Remove the now-unused form-errors-summary container and its translation keys. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
turegjorup
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rimi-itk
commented
Feb 23, 2026
Contributor
Author
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
This looks good! I've added some comments and suggestions.
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…ite root and /admin
…anslate Super Admin Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/_#/tickets/showTicket/5104
Description
Screenshot of the result
If your change affects the user interface you should include a screenshot of the result with the pull request.
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
EventCrudController.php, but I assume that it has something to do with that role be some kind of super user (that has access to everything)User::getOrganizations()andSELECT o FROM Organization o WHERE user MEMBER OF o.users(cf. changes inEventCrudController.php)