6172: Additions for service agreements#280
Open
jeppekroghitk wants to merge 11 commits intodevelopfrom
Open
Conversation
tuj
requested changes
Apr 10, 2026
migrations/Version20260410120000.php
Outdated
| return 'Extend service_agreement with new fields, change system_owner_notice to JSON, make valid_to nullable, add timestamps'; | ||
| } | ||
|
|
||
| public function up(Schema $schema): void |
Contributor
There was a problem hiding this comment.
Regenerate with doctrine:migrations:diff
src/Entity/ServiceAgreement.php
Outdated
| use Symfony\Component\Validator\Context\ExecutionContextInterface; | ||
|
|
||
| #[ORM\Entity(repositoryClass: ServiceAgreementRepository::class)] | ||
| #[ORM\HasLifecycleCallbacks] |
Contributor
There was a problem hiding this comment.
Should extend AbstractBaseEntity instead of setting createdAt/createdBy/etc
https://github.com/itk-dev/economics/blob/develop/src/Entity/AbstractBaseEntity.php
tuj
approved these changes
Apr 10, 2026
|
|
||
| {{ form_start(form) }} | ||
| <div class="selections" {{ stimulus_controller('choices') }}> | ||
| <div class="selections" data-controller="choices eol-required"> |
Contributor
There was a problem hiding this comment.
can this be done with
{{ stimulus_controller('choices eol-required') }}
?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
6172
Description
New fields on ServiceAgreement:
Modified fields:
Styling fixes:
Screenshot of the result
N/A
Checklist