Conversation
jekuaitk
reviewed
Mar 5, 2026
|
|
||
| .selections .choices__item.choices__item--choice.choices__item--selectable.is-highlighted { | ||
| .selections | ||
| .choices__item.choices__item--choice.choices__item--selectable.is-highlighted { |
Contributor
There was a problem hiding this comment.
Are these classes chained together intentionally?
Comment on lines
+52
to
+58
| $getRowAsStrings = | ||
| /** | ||
| * @return string[] | ||
| * | ||
| * @psalm-return list<string> | ||
| */ | ||
| static fn (Row $row): array => array_map( |
Contributor
There was a problem hiding this comment.
I don't think i've ever added docs to static functions. Is this psalms doing?
| * | ||
| * @return void | ||
| * @param string $className the className of the entity to update | ||
| * @param bool $asyncJobQueue handle as asynchronous jobs |
Contributor
There was a problem hiding this comment.
I suppose all of this is some automated tools doing. Does it not detect the parameter $modifiedAfter? Or does it simply just check whether params described in docs exist in the actual function?
Contributor
Author
There was a problem hiding this comment.
Added parameter description.
jekuaitk
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/6855
Description
Checklist