Skip to content

fixed missmatch in body-role, now all incidents are showing up!#69

Merged
SandraNelj merged 1 commit intomainfrom
showactiveincidents
Apr 6, 2026
Merged

fixed missmatch in body-role, now all incidents are showing up!#69
SandraNelj merged 1 commit intomainfrom
showactiveincidents

Conversation

@SandraNelj
Copy link
Copy Markdown
Contributor

@SandraNelj SandraNelj commented Apr 6, 2026

Summary by CodeRabbit

  • Refactor
    • Updated internal template rendering configurations across dashboard and incidents pages with no changes to user-facing functionality.

@SandraNelj SandraNelj merged commit 85ffdd0 into main Apr 6, 2026
2 of 3 checks passed
@SandraNelj SandraNelj self-assigned this Apr 6, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6825f23f-9f02-4c52-bc13-76076b548f9b

📥 Commits

Reviewing files that changed from the base of the PR and between 37ca3ca and 3900010.

📒 Files selected for processing (2)
  • src/main/resources/templates/dashboard.html
  • src/main/resources/templates/incidents.html

📝 Walkthrough

Walkthrough

Two HTML template files updated to replace Thymeleaf inline expression syntax with explicit attribute assignment for the data-role attribute on the body element. No functional changes to client-side logic or server-side behavior.

Changes

Cohort / File(s) Summary
Template Attribute Syntax Updates
src/main/resources/templates/dashboard.html, src/main/resources/templates/incidents.html
Changed data-role attribute rendering from inline expression syntax data-role="[[${role}]]" to explicit Thymeleaf attribute assignment th:attr="data-role=${role}". No functional logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Templates dancing in a cleaner way,
From brackets bold to attributes that play,
th:attr whispers what [[${role}]] once said,
Same magic flows through the template's thread,
A syntax refresh, elegant and bright! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch showactiveincidents

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant