Skip to content

Seed test database with initial data and update initialization proper…#30

Merged
mattknatt merged 1 commit intomainfrom
dev/githubkeys
Apr 2, 2026
Merged

Seed test database with initial data and update initialization proper…#30
mattknatt merged 1 commit intomainfrom
dev/githubkeys

Conversation

@mattknatt
Copy link
Copy Markdown
Collaborator

@mattknatt mattknatt commented Apr 2, 2026

…ties

Summary by CodeRabbit

  • Chores
    • Updated GitHub OAuth2 authentication configuration to ensure proper credential handling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d80c4d30-08a1-49fd-a230-17a50e768745

📥 Commits

Reviewing files that changed from the base of the PR and between 5ec1c30 and 828eb9a.

📒 Files selected for processing (1)
  • src/main/resources/application.properties

📝 Walkthrough

Walkthrough

GitHub OAuth2 client credentials in the application properties configuration were replaced from environment variable placeholders (${GITHUB_CLIENT_ID:none} and ${GITHUB_CLIENT_SECRET:none}) to hard-coded literal values in a single configuration file.

Changes

Cohort / File(s) Summary
OAuth2 Configuration
src/main/resources/application.properties
Replaced GitHub OAuth2 client ID and secret environment variable placeholders with hard-coded literal credential values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Feature/oauth2login #20 — Modified the same GitHub OAuth2 client properties by introducing environment-variable placeholders, which are now replaced with hard-coded values in this PR.

Poem

🐰 A rabbit hops through configs with glee,
OAuth credentials, now plain for all to see!
From ${VARIABLES} to hardcoded strings so bright,
The GitHub door opens—authentication's right! 🔐

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/githubkeys

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mattknatt mattknatt merged commit 172d176 into main Apr 2, 2026
1 of 2 checks passed
@mattknatt mattknatt deleted the dev/githubkeys branch April 2, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant