Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1981 +/- ##
==========================================
+ Coverage 43.17% 43.29% +0.11%
==========================================
Files 575 575
Lines 24620 24688 +68
Branches 8128 8155 +27
==========================================
+ Hits 10630 10688 +58
- Misses 13322 13329 +7
- Partials 668 671 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjd210
left a comment
There was a problem hiding this comment.
This looks good. Took me some time to figure out how portals actually work in the codebase in the first place, even with the new comments. In fact, we could perhaps do with even more comments, but inside the individual portal hook implementations like Table.tsx has. That's outside of this PR's scope however, so I'll make a separate card.
As for the main changes, I can see how the race condition would come up and it makes sense to me that this would fix it, BUT owing to the inconsistency of reproducing theses portal issues in the first place it's hard to be 100% sure that this was the only/entire problem. I've tested as best I can across each of the different portal types and seen no issues, and I don't see how this could possibly make things worse, so I think at this point we should just merge and wait for issues to come in again or not (🤞)
Refactors the main React portal wrapper to use better use hooks and dependencies in order to: