Skip to content

Add Cisco IOS-XR Provider and implement interface stubs #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sven-rosenzweig wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Cisco IOS-XR Provider and implement interface stubs #85

sven-rosenzweig wants to merge 4 commits into from
+664 −35

Conversation

@sven-rosenzweig
Copy link
Contributor

@sven-rosenzweig sven-rosenzweig commented Oct 1, 2025

No description provided.

@sven-rosenzweig sven-rosenzweig force-pushed the feat/iosxrv2 branch 2 times, most recently from 120c4a7 to ff39cee Compare October 1, 2025 15:36
@sven-rosenzweig
Copy link
Contributor Author

sven-rosenzweig commented Oct 1, 2025

Waiting for #30 to be merged.

@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Oct 14, 2025
@hardikdr hardikdr added this to Roadmap Oct 14, 2025
@sven-rosenzweig sven-rosenzweig force-pushed the feat/iosxrv2 branch 2 times, most recently from 32662d3 to 35d7a78 Compare October 31, 2025 16:10
@sven-rosenzweig sven-rosenzweig force-pushed the feat/iosxrv2 branch 3 times, most recently from 0895369 to 9c61755 Compare November 13, 2025 15:02
@sven-rosenzweig sven-rosenzweig marked this pull request as ready for review November 13, 2025 15:14
@sven-rosenzweig sven-rosenzweig requested a review from a team as a code owner November 13, 2025 15:14
felix-kaestner
felix-kaestner reviewed Nov 28, 2025
View reviewed changes
@sven-rosenzweig sven-rosenzweig force-pushed the feat/iosxrv2 branch 5 times, most recently from f73aed6 to 5b12300 Compare December 8, 2025 16:36
felix-kaestner
felix-kaestner approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@felix-kaestner felix-kaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀 Feel free to rebase/squash/merge.

@sven-rosenzweig
fix: Support unencrypted GRPC connections
cb9a926 
Some network devices do not have TLS configured on their side, requiring
the use of insecure credentials. To support these cases, this change
disables transport security enforcement when insecure credentials are
used.

Note: This option is intended for development and testing purposes only.
@sven-rosenzweig
feat: Introduce Client as an interface
bef7f68 
Refactor the Provider to depend on a Client interface instead of a concrete
implementation. This simplifies testing and mocking by allowing the Client
itself to be mocked, rather than individual gRPC calls.
@sven-rosenzweig sven-rosenzweig force-pushed the feat/iosxrv2 branch 2 times, most recently from dc8ad22 to 2dc664e Compare January 8, 2026 15:57
@sven-rosenzweig sven-rosenzweig force-pushed the feat/iosxrv2 branch 2 times, most recently from 2e3c951 to a9247ea Compare January 9, 2026 09:11
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/internal/deviceutil 35.82% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/gnmiext/v2 91.05% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr 48.10% (+48.10%) 🌟
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 12.08% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/internal/deviceutil/deviceutil.go 35.82% (ø) 67 24 43
github.com/ironcore-dev/network-operator/internal/provider/cisco/gnmiext/v2/client.go 89.10% (ø) 156 139 17
github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr/intf.go 46.15% (+46.15%) 13 (+13) 6 (+6) 7 (+7) 🌟
github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr/provider.go 48.48% (+48.48%) 66 (+66) 32 (+32) 34 (+34) 🌟
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf.go 19.33% (ø) 119 23 96
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.08% (ø) 1226 1 1225

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/provider/cisco/gnmiext/v2/client_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr/intf_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr/provider_test.go

@felix-kaestner felix-kaestner changed the title feat: Add Cisco IOS-XR Provider and implement interface stubs Add Cisco IOS-XR Provider and implement interface stubs Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felix-kaestner felix-kaestner felix-kaestner approved these changes

@swagner-de swagner-de Awaiting requested review from swagner-de

Assignees

No one assigned

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Roadmap
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sven-rosenzweig @felix-kaestner @hardikdr