Open
Conversation
This was referenced Feb 15, 2018
Open
ZJONSSON
force-pushed
the
write-pages
branch
from
38775bc to
f2d8355
Compare
* bitpacking should work for any length of data, not just multiple of 8 (last packed is padded if less than 8) * Improve runs estimation - only start a new run if we are at a mod 8 === 0, otherwise use bitpacking
This moves data into encoded buffer as soon as possible, reducing memory requirements for the whole rowGroup
into ParquetReader so they can be called without arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits each column into pages as determined by
pageSize. Encoding into buffer is done as soon as we have enough rows to encode a page, even though the rowBuffer is far from being full. This ideally should reduce memory usage since the encoded pages should be substantially smaller than the shred data. Also pages facilitate scrolling fast through a column, skipping pages of no interest, and also help in locating individual records without having to read the whole column.