If there is an error in transform -> pass error to callback#46
Open
ZJONSSON wants to merge 2 commits intoironSource:masterfrom
Open
If there is an error in transform -> pass error to callback#46ZJONSSON wants to merge 2 commits intoironSource:masterfrom
ZJONSSON wants to merge 2 commits intoironSource:masterfrom
Conversation
ZJONSSON
changed the title
The error will in turn be emitted as an `error` event
…llback are captured subsequently and included in the callback.
ZJONSSON
force-pushed
the
stream-emit-error
branch
from
a78cdfa to
3e75d96
Compare
|
Any chance this can be merged? |
|
Its a useful change to merge in, and would be very much appreciated to capture the rejection rather than silently dying. |
|
Ideally errors would be |
|
Hello, I am facing an issue with the unhandled rejection, is it possible to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #45
The error will in turn be emitted as an
errorevent