Add support for deeply nested schemas#126
Open
MarkOSIndustries wants to merge 1 commit intoironSource:masterfrom
Open
Add support for deeply nested schemas#126MarkOSIndustries wants to merge 1 commit intoironSource:masterfrom
MarkOSIndustries wants to merge 1 commit intoironSource:masterfrom
Conversation
The previous reader implementation made the assumption that the next num_children schema elements were all that was required to reconstruct a given element. This assumption broke down when faced with multiple levels of nesting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous reader implementation made the assumption that the next
num_childrenschema elements were all that was required to reconstruct a given element.This assumption broke down when faced with multiple levels of nesting.
I've added some failing integration tests and then applied a fix to
decodeSchema, which makes them pass.I added the extra schema.js test purely for completeness, it passed fine without alteration.