Closed
Conversation
Author
|
Travis CI got this warning+error, and I ran Looks like this isn't actually an option... |
Author
|
Well, I read the cargo docs and discovered that I made this change incorrectly. I shouldn't have removed |
closes iron#148 - use patch for route-recognizer - add `dyn` to trait objects I guess route-recognizer is no longer maintained? My PR: http-rs/route-recognizer#25 Comment from Alex Crichton: http-rs/route-recognizer#26 (comment)
Member
|
Thanks for the PR! I just merged iron/iron#591, the router crate now lives inside workspace in the main repo (https://github.com/iron/iron/tree/master/router). Could you move the PR? |
Author
|
@phlmn done - iron/iron#614 |
Member
|
Thanks! 🙂 |
Member
|
Moved to iron/iron#614 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #148
I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)