longest spells#597
Merged
Merged
Conversation
xchourio
approved these changes
Feb 23, 2026
remicousin
force-pushed
the
longestspells
branch
from
9ead92b to
a0320c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I came to realize that I need the _cumsum master function to return NaN when all entries are NaN (and not return 0). It makes more sense but it's also motivated by the the all-nan slices everywhere but control scenario. In previous cases, I had methods that had skipna and mincount to deal with that, but max doesn't have that.
I dropped comments but will turn them to doc entries in a later PR.
This probably has an impact on all the other cases, possibly making unncessary all the additional skipna/mincount arguments. I'll also check on that in another later PR.