Conversation
The gap detection filter in computeSubtreeAncestralState() used a fixed threshold (sum > 1.0) that broke for models with multiple rate categories (ncat_mix > 1) and for deep subtrees with scaled partial likelihoods. This caused --scfl to incorrectly filter nearly all sites as gaps, producing wrong sCF values for any model using +G, +R, +I+G, +I+R, or mixture models. The fix uses scale_num to distinguish real data from gaps at internal nodes: scaled sites (scale_num > 0) are always real data, while all-gap subtrees are detected by sum > ncat_mix with no scaling. Leaf nodes retain the original threshold. Both normal and SAFE_NUMERIC scale_num layouts are handled. Fixes #137 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
@bqminh can you take a look at this - would be great to get it into the latest binaries ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--scflgiving incorrect results with any model using multiple rate categories (+G, +R, +I+G, +I+R, mixture models)computeSubtreeAncestralState()used a fixed threshold (sum > 1.0) that broke forncat_mix > 1and for deep subtrees with scaled partial likelihoodsscale_numto distinguish real data from gaps at internal nodes, handling both normal andSAFE_NUMERICmodesTest plan
Validation scripts and full results: https://github.com/roblanf/iqtree3/tree/issue-137/tests/scfl_simulation
Full report of empirical and simulation test results: #137 (comment)
Fixes #137
🤖 Generated with Claude Code