feat: refresh ipns record#891
Open
tabcat wants to merge 77 commits into
Open
Conversation
achingbrain
reviewed
Apr 13, 2026
achingbrain
reviewed
Apr 13, 2026
Contributor
Author
|
this still needs some work. ill convert to ready when its ready for review. |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tabcat
commented
Apr 19, 2026
Comment on lines
+168
to
+176
| // resolve the latest record | ||
| let latestRecord: IPNSRecord | ||
| try { | ||
| const { record } = await this.resolver.resolve(multihashFromIPNSRoutingKey(routingKey)) | ||
| latestRecord = record | ||
| } catch (err: any) { | ||
| this.log.error('unable to find existing record to republish - %e', err) | ||
| continue | ||
| } |
Contributor
Author
There was a problem hiding this comment.
wondering if we should be resolving the latest record for refreshing. this server is set as the republisher for this routingKey. it should be the only one publishing to this key on the network. this could just be an offline resolution.
Resolves conflicts from the multiformats@14 update (ipfs#1039): - publisher.ts unpublish(): keep the branch's wider key parameter type; assign the resolved PublicKey directly rather than its multihash, so type narrowing survives and keyToMultihash() still accepts it without a @ts-expect-error - pb/metadata.ts: keep the IPNSPublishMetadataUpkeepFieldEvent interface alongside main's regenerated Uint8Array<ArrayBuffer> encode() signature Also extends the @ts-expect-error @libp2p/* multiformats shims main added to branch code its sweep predated (utils.ts keyToMultihash, publish/republish specs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
feat: refresh ipns record
Description
Adds
republishto IPNS andunpublishaccepts ipns keys.Changes
resolveto not read localStore ifnocacheoption is true.Changes metadata to include a
refreshfield that is false by default. The#republishmethod reads this field to know which keys are being refreshed.Closes #877
Notes & open questions
Change checklist