Skip to content

Fix: Update type hints for filter_ parameter in find() and find_one() #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamGreenAwardMatcher wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: Update type hints for filter_ parameter in find() and find_one() #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c6702c
Fix type signature for filter_ parameter in find methods
AdamGreenAwardMatcher Aug 2, 2025
156cfc9
Update helpers.py
AdamGreenAwardMatcher Aug 2, 2025
450ce76
Update model.py
AdamGreenAwardMatcher Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions firedantic/_async/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_document_id(self):
@classmethod
async def find( # pylint: disable=too-many-arguments
cls: Type[TAsyncBareModel],
filter_: Optional[Dict[str, Union[str, dict]]] = None,
filter_: Optional[Dict[str, Union[str, int, float, bool, dict]]] = None,
order_by: Optional[_OrderBy] = None,
limit: Optional[int] = None,
offset: Optional[int] = None,
Expand Down Expand Up @@ -224,7 +224,7 @@ def _add_filter(
@classmethod
async def find_one(
cls: Type[TAsyncBareModel],
filter_: Optional[Dict[str, Union[str, dict]]] = None,
filter_: Optional[Dict[str, Union[str, int, float, bool, dict]]] = None,
order_by: Optional[_OrderBy] = None,
transaction: Optional[AsyncTransaction] = None,
) -> TAsyncBareModel:
Expand Down
4 changes: 2 additions & 2 deletions firedantic/_sync/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_document_id(self):
@classmethod
def find( # pylint: disable=too-many-arguments
cls: Type[TBareModel],
filter_: Optional[Dict[str, Union[str, dict]]] = None,
filter_: Optional[Dict[str, Union[str, int, float, bool, dict]]] = None,
order_by: Optional[_OrderBy] = None,
limit: Optional[int] = None,
offset: Optional[int] = None,
Expand Down Expand Up @@ -224,7 +224,7 @@ def _add_filter(
@classmethod
def find_one(
cls: Type[TBareModel],
filter_: Optional[Dict[str, Union[str, dict]]] = None,
filter_: Optional[Dict[str, Union[str, int, float, bool, dict]]] = None,
order_by: Optional[_OrderBy] = None,
transaction: Optional[Transaction] = None,
) -> TBareModel:
Expand Down