fix(factory): recover panics while validating a proposed block#4920
Merged
Conversation
#4840 recovers panics on the mint path so a doomed draft cannot crash the process. A proposed block is likewise untrusted input: extend the same resilience to ValidateBlock so a panic while processing a block's actions is recovered and surfaced as an error (the block is rejected) instead of taking the validating node down. The working set is discarded by the caller on error, so no partial state leaks and no committed state changes; the commit/PutBlock path stays fatal as before. Adds a regression test.
|
envestcc
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4840 recovers panics on the mint path so a doomed draft cannot crash the process. A proposed block is likewise untrusted input, but
ValidateBlockcurrently runs outside any recover, so a panic while processing a proposed block's actions takes the validating node down.This extends the same resilience to the validation path: a panic during
ValidateBlockis recovered and surfaced as an error (the block is rejected) instead of crashing the process.PutBlockpath (trusted data) intentionally stays fatal, as before.iotex_validate_block_panics_totalmetric and a regression test.