fix(evm): drop reserved-topic logs with unexpected topic count#4919
Open
guo wants to merge 3 commits into
Open
fix(evm): drop reserved-topic logs with unexpected topic count#4919guo wants to merge 3 commits into
guo wants to merge 3 commits into
Conversation
After #4868 the reserved in-contract-transfer topic only appears on contract-emitted logs, which are already dropped from the receipt. A malformed one (topic count != 3) was still special-cased; drop it uniformly with the rest so the handling is consistent. Gated on the next upgrade so block replay stays byte-identical before activation. Adds a regression test for the post-upgrade drop path alongside the existing pre-upgrade invariant.
envestcc
reviewed
Jul 13, 2026
…rade After the upgrade, only a well-formed 3-topic reserved-topic log actually collides with the shape AddInContractTransferLog records, so only that one needs to keep being dropped. A malformed one (topic count != 3) doesn't collide with anything and can just be treated like any other event log instead of being discarded. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Correct the previous commit: after the upgrade, AddLog no longer special-cases the reserved in-contract-transfer topic at all, so a log carrying it is recorded as a regular event log regardless of topic count (including the well-formed 3-topic shape). Pre-upgrade behavior is untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
envestcc
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #4868 the reserved in-contract-transfer topic only appears on contract-emitted logs, which are already dropped from the receipt (never appended to
stateDB.logs, soreceipt.Logsand the receipt root are unaffected).A malformed one (topic count != 3) was still special-cased separately. This drops it uniformly with the rest so the reserved-topic handling is consistent.
Gated on the next upgrade (
ToBeEnabled) so block replay stays byte-identical before activation. Adds the post-upgrade regression test alongside the existing pre-upgrade invariant.