Skip to content

fix(ios): http body in error and send progress only when success #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OS-pedrogustavobilro merged 3 commits into from
Feb 4, 2026
Merged

fix(ios): http body in error and send progress only when success #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03a9972
chore: Minor changes in app error display
OS-pedrogustavobilro Jan 26, 2026
11d3db3
chore: Add options in example app for http error
OS-pedrogustavobilro Jan 26, 2026
e32b7e0
fix(ios): http body in error and send progress only when success
OS-pedrogustavobilro Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/capacitor-plugin/CapacitorFileTransfer.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Pod::Spec.new do |s|
s.source = { :git => package['repository']['url'], :tag => s.version.to_s }
s.source_files = 'ios/Sources/FileTransferPlugin/*.{swift,h,m,c,cc,mm,cpp}'
s.ios.deployment_target = '15.0'
s.dependency 'IONFileTransferLib', spec='~> 1.0.1'
s.dependency 'IONFileTransferLib', spec='~> 1.0.2'
s.dependency 'Capacitor'
s.swift_version = '5.1'
end
2 changes: 1 addition & 1 deletion packages/capacitor-plugin/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let package = Package(
],
dependencies: [
.package(url: "https://github.com/ionic-team/capacitor-swift-pm.git", from: "8.0.0"),
.package(url: "https://github.com/ionic-team/ion-ios-filetransfer.git", from: "1.0.1")
.package(url: "https://github.com/ionic-team/ion-ios-filetransfer.git", from: "1.0.2")
],
targets: [
.target(
Expand Down
6 changes: 4 additions & 2 deletions packages/example-app/src/js/file-transfer-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ window.customElements.define(
<option value="">Select a file to download</option>
<option value="https://raw.githubusercontent.com/mozilla/pdf.js/ba2edeae/examples/learning/helloworld.pdf">Small PDF (~1KB)</option>
<option value="https://raw.githubusercontent.com/kyokidG/large-pdf-viewer-poc/58a3df6adc4fe9bd5f02d2f583d6747e187d93ae/public/test2.pdf">Large PDF (~20MB)</option>
<option value="https://raw.githubusercontent.com/mozilla/pdf.js/ba2edeae/examples/learning/invalid.pdf">Non-existent file (HTTP 404)</option>
</select>
<input type="url" id="customDownloadUrl" placeholder="Or enter custom URL">
</div>
Expand Down Expand Up @@ -141,6 +142,7 @@ window.customElements.define(
<select id="uploadUrl" class="url-select">
<option value="">Select an upload endpoint</option>
<option value="https://httpbin.org/post">HTTPBin (Test File Upload)</option>
<option value="https://api.github.com/repos/octocat/Spoon-Knife/issues">Non-Upload URL (HTTP error)</option>
</select>
<input type="url" id="customUploadUrl" placeholder="Or enter custom URL">
</div>
Expand Down Expand Up @@ -251,7 +253,7 @@ window.customElements.define(
});
}
} catch (error) {
this.showError('Directory initialization error: ' + error.message);
this.showError('Directory initialization error: ' + error.code + " -> " + error.message);
}
}

Expand Down Expand Up @@ -322,7 +324,7 @@ window.customElements.define(

this.showResponse('Download completed', result);
} catch (error) {
this.showError('Download failed: ' + error.message);
this.showError('Download failed: ' + JSON.stringify(error, null, 2));
}
}

Expand Down