Skip to content

fix(web): Close button not resolving promise #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OS-ruimoreiramendes merged 6 commits into from
Feb 6, 2026
Merged

fix(web): Close button not resolving promise #116

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b32e803
fix(web): Fix promise when press close button
OS-ruimoreiramendes Feb 6, 2026
42498e4
remove empty space
OS-ruimoreiramendes Feb 6, 2026
df0fe75
lint web.ts
OS-ruimoreiramendes Feb 6, 2026
76ca9fa
revert changes on example app
OS-ruimoreiramendes Feb 6, 2026
ae2cb44
remove empty space
OS-ruimoreiramendes Feb 6, 2026
79c64a2
added extra line
OS-ruimoreiramendes Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions plugin/src/web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ export class CapacitorBarcodeScannerWeb

const caposbarcodescannercontainerdialoginnerclose =
document.createElement("span");
caposbarcodescannercontainerdialoginnerclose.id =
"cap-os-barcode-scanner-close-button";
caposbarcodescannercontainerdialoginnerclose.className = "close-button";
caposbarcodescannercontainerdialoginnerclose.innerHTML = "×";
caposbarcodescannercontainerdialoginner.appendChild(
Expand Down Expand Up @@ -95,9 +97,6 @@ export class CapacitorBarcodeScannerWeb
caposbarcodescannercontainer.appendChild(
caposbarcodescannercontainerdialog,
);

caposbarcodescannercontainerdialoginnerclose.onclick =
this.stopAndHideScanner;
}

/**
Expand Down Expand Up @@ -134,6 +133,19 @@ export class CapacitorBarcodeScannerWeb
scannerFPS: options.web?.scannerFPS ? options.web.scannerFPS : 50,
};

let alreadyCancelled = false;
const closeButton = document.getElementById(
"cap-os-barcode-scanner-close-button",
);
if (closeButton) {
closeButton.onclick = async () => {
if (alreadyCancelled) return;
alreadyCancelled = true;
await this.stopAndHideScanner();
reject(new Error("Couldn’t scan because the process was cancelled."));
};
}

// Set up and start the scanner
const scannerElement = document.getElementById(
"cap-os-barcode-scanner-container-scanner",
Expand Down