Modlog #345
Modlog #345
Conversation
Check add/remove status for lemmy log types.
|
Sure, I'm a bit busy this week, but I'll take a look when I get a chance! At first glance, since the mod log is quite a dense view in general, maybe we'd want to ditch the cards and just use dividers between items (or at least see what it looks like). |
|
Removed the cards and added some dividers. I reckon this does look better. |
Change layout of modlog items - Remove card. - Add dividers between sections.
|
Yeah, it does seem like we'd need to remove the dividers that are within each report, though. It took me a minute while looking at the screenshot, because it looked like the sections with "Content:" were a whole separate report. Besides that I think it looks pretty good, and I like the color coded flairs that are used for the different mod log types. |
Fix lemmy ban type enum. Fix modlog filter icon.
Fix navigate to mod added/removed.
|
Think I've gotten everything. Mbin has less functionality as some things aren't returned in the API response. Mod added/removed and post pinned/unpinned won't link to the corresponding item as the user and post aren't available in the response. I think everything else should work though. |
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Looks good! Would you be able to create an issue on https://github.com/MbinOrg/mbin/ listing everything that's missing from the modlog API?
I did notice the row for posts that has the user/community is able to overflow:
Include microblog modlog types with corresponding post types.
|
Made an issue here. The user/community info should wrap now when there's not enough space. It's the same widget thats used for posts and comments so the user/community will wrap there too. |
Thank you!
I could be remembering wrong, but I believe previously the content info widget should have truncated the community and user names to prevent overflowing, so I thought we could just do the same here. I could work on that though, unless you want to. |
|
That would be better. I looked through the diff of #304 with the post layout change and couldn't see where the user/community names would be truncated and can't think of any other PRs where it might have changed but if you have an idea of how to do it then that would be great. |
|
It took a while, but I found the commit where I made it so the names would get truncated: 36c9860 It seems like the changes have been undone at some point between then and now (probably when |
This reverts commit 3ab0851.
Switch from manual padding of content info items to using row spacing.
|
Awesome thanks. Was just missing correct placement of |
Adds modlog for Mbin and lemmy (Piefed doesn't have API support yet).
Modlog is available from community menu for Mbin and from both community and user menus for Lemmy.
Also have a instance level modlog under the 'About' page in settings. We should probably add an instance page with instance info (admins, rules, etc) where this would be better placed but for now I figured under About made most sense.
Still needs a lot of testing but some feedback would be good. Should I include the deleted post/comment in the UI since you sort of expect to see unpleasant stuff in the modlog or should I obscure them.