fix: orders API get_chance 반환 타입 및 OrderCreated 모델 수정#40
Merged
interruping merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
- get_chance()가 list[OrderChance] 대신 OrderChance를 반환하도록 수정 (Upbit API가 단일 객체를 반환하나 리스트로 처리하고 있었음) - OrderCreated 모델에서 remaining_volume, prevented_volume, prevented_locked을 optional로 변경 (시장가 주문 응답에 해당 필드가 포함되지 않음) - 동기/비동기 양쪽 모두 수정, mock 테스트도 함께 수정 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
Summary
get_chance()반환 타입을list[OrderChance]→OrderChance로 수정 (Upbit API는 단일 객체 반환)OrderCreated모델의remaining_volume,prevented_volume,prevented_locked을 optional로 변경 (시장가 주문 응답에 미포함)Test plan
uv run pytest tests/api/test_orders.py— 기존 mock 테스트 통과🤖 Generated with Claude Code