[PB-6107]: feature/override file versioning for a given user#990
Open
[PB-6107]: feature/override file versioning for a given user#990
Conversation
|
apsantiso
reviewed
Mar 16, 2026
Comment on lines
+425
to
+436
| if (label === LimitLabels['FileVersionEnabled']) { | ||
| if (!tierId) { | ||
| throw new BadRequestException( | ||
| `tierId is required for feature '${externalLimitName}'`, | ||
| ); | ||
| } | ||
|
|
||
| const limit = await this.limitsRepository.findLimitByLabelAndTier( | ||
| tierId, | ||
| label, | ||
| ); | ||
|
|
Collaborator
There was a problem hiding this comment.
It would be good if we can provide the support team with something like: "choose the feature you want to set for the user" and give them multiple options that are fetched from this API so you do not need to provide the tierId to do things like this.
Example:
- You create an endpoint to fetch some limits with their id, label and value
- Use that endpoint to fetch data for the support bot and give the support team the option to choose between all the limits fetched
- The support team chooses one of the limits
- You have already de limit id and label so you can just set the overridden limit here.
(just and idea for the future) @xabg2
apsantiso
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable file versioning from the gateway for a given user with the
tierId.