[PB-6023]: feat: implement bulk folder creation#965
Open
[PB-6023]: feat: implement bulk folder creation#965
Conversation
jzunigax2
force-pushed
the
feat/bulk-create-folders
branch
from
70aa9a1 to
cb561d9
Compare
sg-gs
reviewed
Mar 4, 2026
sg-gs
reviewed
Mar 5, 2026
| async createBulkFolders(user: User, dto: CreateFolderDto): Promise<Folder[]> { | ||
| const folders = dto.folders; | ||
|
|
||
| const parentFolder = await this.folderRepository.findOne({ |
Member
There was a problem hiding this comment.
Should we filter by removed = false for consistency reasons?
sg-gs
reviewed
Mar 5, 2026
src/modules/folder/folder.usecase.ts
Outdated
| const plainNames = folders.map((f) => f.plainName); | ||
| const uniqueNames = new Set(plainNames); | ||
| if (uniqueNames.size !== plainNames.length) { | ||
| throw new BadRequestException('Duplicate folder names in request'); |
Member
There was a problem hiding this comment.
Wasn't this a 409 conflict or am I remembering it wrong?
…tion for duplicate names and filter removed parent folders
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /folders/bulkto create up to 15 folders under the same parent in a single request