[PB-5937] feature/upload logic #386
Open
CandelR wants to merge 7 commits intofeature/PB-5937-file-upload-logicfrom
Open
[PB-5937] feature/upload logic #386CandelR wants to merge 7 commits intofeature/PB-5937-file-upload-logicfrom
CandelR wants to merge 7 commits intofeature/PB-5937-file-upload-logicfrom
Conversation
Contributor
CandelR
commented
Mar 13, 2026
CandelR
commented
- Implemented file upload logic and encryption in share extension
TamaraFinogina
requested changes
Mar 16, 2026
CandelR
force-pushed
the
feature/PB-5937-file-upload-logic
branch
from
43d7078 to
4d75ace
Compare
…-file-upload-logic-and-encription-2
… with tests to compare with drive-web implementation
|
| import { generateFileKey } from '../../network/crypto'; | ||
|
|
||
| /** Cryptographically secure random bytes via Hermes globalThis.crypto */ | ||
| const generateSecureRandomBytes = (size: number): Buffer => { |
There was a problem hiding this comment.
Maybe using noble is easier, it's already in dependencies anyway
import { randomBytes } from '@noble/hashes/utils.js';
const randomBytesArray = randomBytes(size);
| }; | ||
|
|
||
| /** RIPEMD160 via @noble/hashes/legacy (pure-JS) — share extension can't link arbitrary native modules */ | ||
| export const computeRipemd160Digest = (input: Buffer | string): Buffer => { |
There was a problem hiding this comment.
I think you never use string input, so maybe it can be just buffer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.