Fix: handle device creation errors and improve error handling in device fetching#276
Open
Fix: handle device creation errors and improve error handling in device fetching#276
Conversation
AlexisMora
reviewed
Mar 19, 2026
Comment on lines
48
to
49
| .catch(() => { | ||
| setDeviceState({ status: 'ERROR' }); |
There was a problem hiding this comment.
if getOrCreateDevice is already wrapped in tryCatch this is not necessary right
| const devices = await window.electron.devices.getDevices(); | ||
| setDevices(devices); | ||
| try { | ||
| const devices = await window.electron.devices.getDevices(); |
There was a problem hiding this comment.
You could wrap the device/service.ts getDevices in a tryCatch instead so that every caller of this method is already safe
| const result = await fetchDevice({ deviceIdentifier: data }); | ||
| return await handleFetchDeviceResult(result); | ||
| } | ||
| try { |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
The user is experiencing an unusual issue with the preferences interface. The only relevant error in the logs relates to device creation, which is likely the root cause. It appears that an unresolved creation promise is propagating errors to the UI and causing the interface problems.
Solution implemented: Added catch blocks to prevent error propagation to the interface. This should resolve the issue by handling the promise rejection gracefully.