Skip to content

[_] Remove free field, make aux optional#41

Merged
TamaraFinogina merged 2 commits intomasterfrom
simplify_symmetric
Mar 20, 2026
Merged

[_] Remove free field, make aux optional#41
TamaraFinogina merged 2 commits intomasterfrom
simplify_symmetric

Conversation

@TamaraFinogina
Copy link
Contributor

@TamaraFinogina TamaraFinogina commented Mar 19, 2026

Description

Noble and WebCrypto API seem to expect the IV to be 12 bytes. I removed the free field and made the aux an optional parameter (as it is in noble and webCrypto)

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

unit tests

Additional Notes

This includes changes from another PR #38, which was set to draft

@TamaraFinogina TamaraFinogina self-assigned this Mar 19, 2026
@sonarqubecloud
Copy link

@TamaraFinogina TamaraFinogina merged commit 2a30197 into master Mar 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants