Add GPU support;Use resource limits for resource detection#24
Merged
Merged
Conversation
b4c3f9d to
27fe0d9
Compare
Member
|
Thank you @chihchun1011 , we are almost there with the checks! |
27fe0d9 to
9480993
Compare
Signed-off-by: Chih-Chun Kuo <b06901164@ntu.edu.tw>
9480993 to
f9180ce
Compare
Member
|
I'm approving this; the only left test failure is a flake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes two changes:
Switches resource detection from
requeststolimitsfor CPU, memory, and GPU.Adds automatic GPU passthrough. When
nvidia.com/gpuis present inlimits, the plugin automatically injects the--nvflag into Singularity options to enable NVIDIA runtime support inside the container.A test manifest (
tests/gpu_k8s.yaml) is included to validate GPU end-to-end vianvidia-smi.Changes
resources.limitsinstead ofresources.requests.--nvinto Singularity options whennvidia.com/gpuis detected.tests/gpu_k8s.yaml— runsnvidia-smivia the Interlink HTCondor virtual node.Testing
kubectl apply -f tests/gpu_k8s.yaml # Expected: nvidia-smi lists GPUs, CUDA_VISIBLE_DEVICES=0,1