Skip to content

Updated virtual-kubelet-configuration file to handle podCIDR #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bianco95 wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −0
Open

Updated virtual-kubelet-configuration file to handle podCIDR #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f8e435
Updated virtual-kubelet-configuration file to handle podCIDR
Bianco95 Jul 3, 2025
2537bb2
updated virtual-kubelet-config template to handle null podCIDR
Bianco95 Jul 22, 2025
d31c7e5
Merge branch 'main' of github.com:interlink-hq/interlink-helm-chart i…
Bianco95 Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions interlink/templates/virtual-kubelet-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ data:
Model: "{{ .model }}"
Available: {{ .available }}
{{- end }}
{{- if .Values.virtualNode.podCIDR }}
PodCIDR:
Subnet: {{ .Values.virtualNode.podCIDR.subnet }}
MinIP: {{ .Values.virtualNode.podCIDR.minIP }}
MaxIP: {{ .Values.virtualNode.podCIDR.maxIP }}
{{- end }}
Comment on lines +58 to +63

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block only checks that virtualNode.podCIDR exists, but it will still render Subnet/MinIP/MaxIP as <no value> if any sub-keys are missing (e.g., podCIDR: {} or partially specified values), which can produce an invalid YAML config for the consumer. Consider switching to with on podCIDR (empty maps evaluate false) and/or guarding/requiring the individual fields before rendering them; also quoting Subnet would align with the rest of the template’s string handling.

Suggested change
{{- if .Values.virtualNode.podCIDR }}
PodCIDR:
Subnet: {{ .Values.virtualNode.podCIDR.subnet }}
MinIP: {{ .Values.virtualNode.podCIDR.minIP }}
MaxIP: {{ .Values.virtualNode.podCIDR.maxIP }}
{{- end }}
{{- with .Values.virtualNode.podCIDR }}
{{- if and .subnet .minIP .maxIP }}
PodCIDR:
Subnet: {{ .subnet | quote }}
MinIP: {{ .minIP | quote }}
MaxIP: {{ .maxIP | quote }}
{{- end }}
{{- end }}

Copilot uses AI. Check for mistakes.
HTTP:
Insecure: {{ .Values.virtualNode.HTTP.insecure }}
CaCert: {{ .Values.virtualNode.HTTP.CACert }}
Expand Down
4 changes: 4 additions & 0 deletions interlink/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ virtualNode:
# - resourceType: nvidia.com/gpu
# model: a100
# available: 1
# podCIDR:
# subnet: 10.42.122.0/24
# minIP: 2
# maxIP: 250
Comment on lines +67 to +70

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented podCIDR example is currently indented under virtualNode.resources, but the template reads .Values.virtualNode.podCIDR. If users uncomment this as-is, the chart will not render the PodCIDR config. Move the example to be a sibling of resources (same indentation as HTTPProxies/HTTP).

Suggested change
# podCIDR:
# subnet: 10.42.122.0/24
# minIP: 2
# maxIP: 250
# podCIDR:
# subnet: 10.42.122.0/24
# minIP: 2
# maxIP: 250

Copilot uses AI. Check for mistakes.
HTTPProxies:
HTTP: null
HTTPs: null
Expand Down
Loading