Fix bug where output/inOut connection is incorrectly pruned when unnamed#644
Merged
mkorbel1 merged 12 commits intointel:mainfrom Jan 18, 2026
Merged
Fix bug where output/inOut connection is incorrectly pruned when unnamed#644mkorbel1 merged 12 commits intointel:mainfrom
mkorbel1 merged 12 commits intointel:mainfrom
Conversation
…me assertion failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
There was a bug where if an output of a module was driving an inOut of another module, and the intermediate signal was not strongly named, the internal signals could get pruned away, causing a null exception due to naming selection assumptions being violated.
Related Issue(s)
N/A
Testing
Added new test that failed without the fix
Backwards-compatibility
No
Documentation
No