Skip to content

Logging fixes#32

Merged
mkorbel1 merged 1 commit intointel:mainfrom
mkorbel1:logging_Fixes
Jan 2, 2026
Merged

Logging fixes#32
mkorbel1 merged 1 commit intointel:mainfrom
mkorbel1:logging_Fixes

Conversation

@mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented Jan 2, 2026

Description & Motivation

Fixes to some logging behavior:

  • Fixed a bug where if the logger was used but not yet configured, a null fileSink in RohdBridgeLogger would be used and cause a "Null check operator used on a null value" exception
  • Added tests around RohdBridgeLogger (both with and without configuration)
  • Fixed a bug where if the directory path to a provided log file did not exist, it would crash instead of creating the necessary directory structure
  • Deprecated the logger argument in BridgeModule.buildAndGenerateRTL since it should just use the default RohdBridgeLogger instead.
  • Deprecated enableDebugMesage in RohdBridgeLogger, as it had no effect and was mistakenly left after some refactors.
  • Deprecated fileSink in RohdBridgeLogger, since it should have been kept as an internal or private utility.
  • Fixed some documentation typos

Thank you to @RossComputerGuy for finding and reporting some of these problems on Discord (https://discord.com/channels/1001179329411166267/1001179329411166270/1456454196340719829).

Related Issue(s)

N/A

Testing

Added new tests

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No, API docs and deprecation annotations updated

@mkorbel1 mkorbel1 merged commit 0253971 into intel:main Jan 2, 2026
2 checks passed
@mkorbel1 mkorbel1 deleted the logging_Fixes branch January 2, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant