Enable precompiled headers#122
Conversation
| @@ -0,0 +1,25 @@ | |||
| /*****************************************************************************\ | |||
There was a problem hiding this comment.
I guess this file was added to the commit by mistake. Please remove it.
| @@ -0,0 +1,25 @@ | |||
| /*****************************************************************************\ | |||
There was a problem hiding this comment.
I'm not sure we need this custom exception class, because we never throw it, do we?
There was a problem hiding this comment.
We catch this in common_clang.cpp:346 as std::domain_error, do you mean this kind of exception will never be hit?
| @@ -0,0 +1,16 @@ | |||
| module cl12spir { | |||
There was a problem hiding this comment.
Can we re-use the existing module.modulemap from clang/lib/Headers?
There was a problem hiding this comment.
Technically yes, but we have the motivation to split out the common built-ins which doesn't relate to cl12/cl20 version, to reduce the duplication in generated pcm. So it's better we have a customized modulemap in our own repo.
| @@ -41,11 +85,30 @@ else() | |||
| pack_to_obj(opencl-c.h opencl-c.h.cpp "PCM_OPENCL_C_H") | |||
| list(APPEND CL_HEADERS_SRC | |||
| opencl-c.h.cpp | |||
There was a problem hiding this comment.
I wonder why opencl-c-base.h is not here: it was added last year in llvm.org.
There was a problem hiding this comment.
On release-80 branch, clang doesn't have opencl-c-base.h. In the pull request for ocl-open-90, 100, master branch, there is opencl-c-base.h.
3 participants
No description provided.