update - ELC default mode now called power optimized #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Energy Latency Control (ELC) mode naming from "default" to "power-optimized" throughout the codebase for improved clarity. It also updates the build system to fetch the bhs-power-mode.sh script directly from the upstream PCM repository instead of relying on the PCM submodule.
Changes:
- Renamed ELC mode from "default" to "power-optimized" across all references
- Updated Makefile to fetch
bhs-power-mode.shfrom upstream PCM repository - Updated comments and logic to reflect the new terminology
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Makefile | Added direct download of bhs-power-mode.sh from upstream PCM repository and updated copy path |
| internal/extract/power.go | Changed "Default" mode string to "Power Optimized" in ELC detection logic |
| cmd/config/set.go | Updated ELC mode argument from "default" to "optimized-power-mode" |
| cmd/config/restore.go | Updated comment example from "Default" to "Power-Optimized" |
| cmd/config/flag_groups.go | Updated valid ELC options from "default" to "power-optimized" |
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
…wer Optimized' Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
…wer Optimized' Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
… elc-power-optimized
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
…for new values Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling and naming of ELC (Energy Latency Control) modes throughout the codebase to improve clarity and consistency. The main change is renaming the "default" ELC mode to "power-optimized" and updating related logic, comments, and scripts accordingly. Additionally, the Makefile now fetches the
bhs-power-mode.shscript directly from the upstream repository.ELC mode renaming and logic updates:
"default"to"power-optimized"in option lists, comments, and logic, ensuring consistent terminology throughout the codebase. [1] [2] [3] [4] [5]Build and tooling improvements:
tools/Makefileto fetchbhs-power-mode.shdirectly from the upstream PCM repository and adjusted the copy path to use the downloaded script instead of the one in the PCM submodule. [1] [2]