MigTD: Fix REPORTSTATUS_FLAGS overwrite for in-flight requests#714
Open
haitaohuang wants to merge 1 commit intointel:mainfrom
Open
MigTD: Fix REPORTSTATUS_FLAGS overwrite for in-flight requests#714haitaohuang wants to merge 1 commit intointel:mainfrom
haitaohuang wants to merge 1 commit intointel:mainfrom
Conversation
When a duplicate mig_request_id arrives while a request is in-flight and report_status has not yet polled the flag after the interrupt: 1. Request 42 accepted: FLAGS[42] = AtomicBool(false), REQUESTS adds 42 2. Request 42 calls report_status, which issues vmcall then yields 3. VMM responds with interrupt, callback sets FLAGS[42] to true 4. Async runtime polls wait_for_request before report_status: duplicate request 42 overwrites FLAGS[42] = AtomicBool(false) 5. report_status polls FLAGS[42], sees false, returns Pending 6. No further interrupt will fire for this vmcall — poll hangs forever Fix by moving FLAGS insertion inside the new-request-only path. Also consolidate repeated contains()+insert() into try_accept_request() helper for consistency. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Haitao Huang <haitaohuang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a duplicate mig_request_id arrives while a request is in-flight and report_status has not yet polled the flag after the interrupt:
Fix by moving FLAGS insertion inside the new-request-only path. Also consolidate repeated contains()+insert() into try_accept_request() helper for consistency.