spherical sampling#5
Conversation
|
| StructuredData structured_data(min,max,num_pts,num_components,false); | ||
| std::vector<bool> processed(num_components); | ||
|
|
||
| std::cout<<num_components; |
There was a problem hiding this comment.
this should probably be removed?
| return structured_data; | ||
|
|
||
| } | ||
| StructuredData write_to_vertex_spherical(const std::array<unsigned int,3> &num_pts) |
There was a problem hiding this comment.
why is this called "write to vertex"?
| std::vector<bool> processed(num_components); | ||
|
|
||
|
|
||
| for(unsigned int i=0;i<num_components;++i){ | ||
| processed[i]=false; | ||
| } |
There was a problem hiding this comment.
| std::vector<bool> processed(num_components); | |
| for(unsigned int i=0;i<num_components;++i){ | |
| processed[i]=false; | |
| } | |
| std::vector<bool> processed(num_components, false); |
| } | ||
| } | ||
| else{ | ||
| std::cout<<"unacceptable number of arguments"; |
There was a problem hiding this comment.
can you print a help text how to use this code?
|
|
||
|
|
||
| } | ||
| StructuredData(){ |
There was a problem hiding this comment.
is this constructor necessary?
| StructuredData(){ | ||
|
|
||
| } | ||
| Point<3,double> spherical_to_cartesian_coordinates(const std::array<double,3> &spherical_coord){ |
There was a problem hiding this comment.
| Point<3,double> spherical_to_cartesian_coordinates(const std::array<double,3> &spherical_coord){ | |
| Point<3,double> spherical_to_cartesian_coordinates(const std::array<double,3> &spherical_coord) const { |
| return cartesian_coord; | ||
|
|
||
| } | ||
| Point<3,double> spherical_to_cartesian_coordinates(Point<3,double> &spherical_coord){ |
There was a problem hiding this comment.
| Point<3,double> spherical_to_cartesian_coordinates(Point<3,double> &spherical_coord){ | |
| Point<3,double> spherical_to_cartesian_coordinates(Point<3,double> &spherical_coord) const{ |
|
|
||
| } | ||
| std::array<double,3> | ||
| cartesian_to_spherical_coordinates(const Point<3> &position) |
There was a problem hiding this comment.
in general, can you remove unnecessary empty lines within functions but add them between functions?
| } | ||
| return location; | ||
| } | ||
| Point<3,double> index_to_location_spherical(const //returns cartesian coordinates given an index |
There was a problem hiding this comment.
this is an uncommon way to comment a function!
There was a problem hiding this comment.
Please delete the two files and squash your commits.
You will need to rebase to the current master to be able to merge.
I know it is incomplete, but maybe we should merge and improve from there? Do you have other incomplete work that should be put in or can we merge?
| @@ -0,0 +1,7 @@ | |||
| [ | |||
There was a problem hiding this comment.
please remove this file
| @@ -0,0 +1,54 @@ | |||
| # Install script for directory: /home/quang/Documents/viz-tools/step-40 | |||
There was a problem hiding this comment.
please remove this file
2 participants
No description provided.