WIP: Choose root Schema for standalone sub-schema file#41
Open
rpgoldman wants to merge 2 commits intoinstrumenta:masterfrom
Open
WIP: Choose root Schema for standalone sub-schema file#41rpgoldman wants to merge 2 commits intoinstrumenta:masterfrom
rpgoldman wants to merge 2 commits intoinstrumenta:masterfrom
Conversation
Allow the user to choose a root schema and pull out a self contained json schema .json file for that schema. Adds "--root" argument.
Previously, when giving the --root argument, you would get all the files o2js would ordinarily generate *and* the requested standalone file for the root. Now we don't generate the unnecessary files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the user to choose a root schema and pull out a self contained json schema .json file for that schema. Does so by
adding "--root" argument.
This is useful because an OpenAPI API spec may have, for example, a definition for one or more input and output schemas, and it's desirable to be able to check these schemas individually.
I found that a lot of the schema checkers I tried were not reliably able to handle the cross-file
$reflinks emitted by the previous version ofopenapi2jsonschema.This also removes the lower-casing of the output files, which causes errors on a case-sensitive filesystem.
I'm afraid I don't know how add tests for this because I'm not usually a
poetryuser, nor do I understand howclickworks.