feat: add audio channels to presets #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version to 8.1.0-beta.5 and introduces audio channel configuration support across built-in presets, along with a fix for MPEG-DASH timing issues.
- Added
audio_channelsparameter to all preset classes (H264, AAC, DASH variants) with default value of 2 - Fixed MPEG-DASH timing issues by using
avoid_negative_ts 'make_zero'instead of the asetpts filter - Added
video_syncmethod to RawCommandArgs for video synchronization control
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/ffmpeg/version.rb | Version bumped from 8.1.0-beta.4 to 8.1.0-beta.5 |
| lib/ffmpeg/raw_command_args.rb | Added video_sync method for video synchronization |
| lib/ffmpeg/presets/h264.rb | Added audio_channels parameter with default value of 2 |
| lib/ffmpeg/presets/dash/h264.rb | Removed asetpts filter and added audio_channels support |
| lib/ffmpeg/presets/dash/aac.rb | Added audio_channels parameter with default value of 2 |
| lib/ffmpeg/presets/dash.rb | Added avoid_negative_ts configuration to fix timing issues |
| lib/ffmpeg/presets/aac.rb | Added audio_channels parameter with default value of 2 |
| CHANGELOG | Documented improvements and fixes for version 8.1.0-beta.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bajankristof
force-pushed
the
feat/preset-improvements
branch
3 times, most recently
from
ba59502 to
6ac61a7
Compare
kiskoza
requested changes
Nov 3, 2025
bajankristof
force-pushed
the
feat/preset-improvements
branch
from
6ac61a7 to
16078d7
Compare
* Also fixes some issues with MPEG-DASH timings (uses avoid_negative_ts 'make_zero' instead of the asetpts filter). * Also adds some new methods to check for the FFmpeg and FFprobe binary versions. Refs: ARC-11152
bajankristof
force-pushed
the
feat/preset-improvements
branch
from
16078d7 to
6a11692
Compare
kiskoza
approved these changes
Nov 3, 2025
ZoltanDalmadi
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.