Skip to content

Conversation

@bajankristof
Copy link
Collaborator

Refs: ARC-11095

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds audio sample rate adjustment functionality to FFMPEG presets, similar to existing frame rate handling. It ensures audio is encoded at appropriate sample rates by setting a default of 48kHz and using the closest standard sample rate when input rates are lower than targets.

  • Audio sample rate parameter added to all built-in presets with 48kHz default
  • New audio sample rate adjustment logic implemented with standard rate fallbacks
  • Comprehensive test coverage added for various audio sample rate scenarios

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/ffmpeg/command_args.rb Implements audio sample rate adjustment logic with standard rates array
lib/ffmpeg/presets/h264.rb Adds audio_sample_rate parameter to all H264 preset methods and class
lib/ffmpeg/presets/aac.rb Adds audio_sample_rate parameter to AAC preset methods and class
lib/ffmpeg/presets/dash/h264.rb Updates DASH H264 presets to pass audio_sample_rate parameter
lib/ffmpeg/presets/dash/aac.rb Updates DASH AAC presets to pass audio_sample_rate parameter
spec/ffmpeg/command_args_spec.rb Adds comprehensive test coverage for audio sample rate adjustment
lib/ffmpeg/version.rb Version bump to 8.1.0-beta.4
CHANGELOG Documents the new audio sample rate features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bajankristof bajankristof merged commit a802096 into main Oct 14, 2025
13 checks passed
@bajankristof bajankristof deleted the feat/audio-sample-rate branch October 14, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants