🧪 Add tests for calculateTTL and calculateExpiration#23
Conversation
- Add src/lib/validation.test.ts using node:test - Test calculateTTL with future, past, and current timestamps - Test calculateExpiration with all expiration types - Use t.mock.timers for deterministic testing - Update re-exports in src/lib/validation.ts with .ts extensions for test runner compatibility Co-authored-by: instax-dutta <54683866+instax-dutta@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 What: The testing gap addressed
This PR adds unit tests for the core validation and timestamp calculation logic in
src/lib/validation.ts. Specifically, it addresses a missing edge case forcalculateTTLwhen provided with an expired timestamp.📊 Coverage: What scenarios are now tested
✨ Result: The improvement in test coverage
By adding these tests, we ensure that the expiration logic—which is critical for both the database (Turso) and the payload storage (Redis)—is accurate and handles boundary conditions correctly. The use of
node:testwithmock.timersensures these tests are fast and deterministic.PR created automatically by Jules for task 16264536599457273014 started by @instax-dutta