Skip to content

🧪 Add tests for calculateTTL and calculateExpiration#23

Open
instax-dutta wants to merge 1 commit into
mainfrom
testing-improvement-validation-16264536599457273014
Open

🧪 Add tests for calculateTTL and calculateExpiration#23
instax-dutta wants to merge 1 commit into
mainfrom
testing-improvement-validation-16264536599457273014

Conversation

@instax-dutta

Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed

This PR adds unit tests for the core validation and timestamp calculation logic in src/lib/validation.ts. Specifically, it addresses a missing edge case for calculateTTL when provided with an expired timestamp.

📊 Coverage: What scenarios are now tested

  • calculateTTL:
    • Future timestamps (returns correct seconds)
    • Past timestamps (returns 0) - requested edge case
    • Current timestamp (returns 0)
    • Undefined input (returns undefined)
    • Result flooring (e.g., 5500ms -> 5s)
  • calculateExpiration:
    • 'never' -> undefined
    • '5min', '1hour', '1day', '7days', '30days' -> correct relative timestamps
    • 'views', 'burn' -> undefined

✨ Result: The improvement in test coverage

By adding these tests, we ensure that the expiration logic—which is critical for both the database (Turso) and the payload storage (Redis)—is accurate and handles boundary conditions correctly. The use of node:test with mock.timers ensures these tests are fast and deterministic.


PR created automatically by Jules for task 16264536599457273014 started by @instax-dutta

- Add src/lib/validation.test.ts using node:test
- Test calculateTTL with future, past, and current timestamps
- Test calculateExpiration with all expiration types
- Use t.mock.timers for deterministic testing
- Update re-exports in src/lib/validation.ts with .ts extensions for test runner compatibility

Co-authored-by: instax-dutta <54683866+instax-dutta@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Mar 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
binify Error Error Mar 22, 2026 9:35am

@coderabbitai

coderabbitai Bot commented Mar 22, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@instax-dutta has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8a4483e5-6e78-4efa-84c0-f492823d0dce

📥 Commits

Reviewing files that changed from the base of the PR and between 6c75fd8 and 372f037.

📒 Files selected for processing (2)
  • src/lib/validation.test.ts
  • src/lib/validation.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch testing-improvement-validation-16264536599457273014

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant