Skip to content

πŸ”’ Fix IP Address Spoofing via X-Forwarded-For#16

Open
instax-dutta wants to merge 1 commit into
mainfrom
security-fix-ip-spoofing-8564156710181733307
Open

πŸ”’ Fix IP Address Spoofing via X-Forwarded-For#16
instax-dutta wants to merge 1 commit into
mainfrom
security-fix-ip-spoofing-8564156710181733307

Conversation

@instax-dutta

Copy link
Copy Markdown
Owner

This PR fixes a security vulnerability where an attacker could spoof their IP address by providing a custom X-Forwarded-For header.

The previous implementation blindly trusted the first IP in the X-Forwarded-For list, which is often client-controlled. The new implementation prioritizes the X-Real-IP header (typically set by trusted infrastructure like Vercel) and falls back to the last IP in the X-Forwarded-For list, which is the most reliable entry in a proxy chain.

Key changes:

  • Created src/lib/ip.ts for secure IP retrieval logic.
  • Updated src/app/api/paste/route.ts to use the improved utility.
  • Added src/lib/ip.test.ts with 6 test cases verifying the security and robustness of the fix.
  • Removed the vulnerable code from src/lib/validation.ts.

PR created automatically by Jules for task 8564156710181733307 started by @instax-dutta

- Moved getClientIp to a dedicated src/lib/ip.ts utility.
- Updated implementation to prioritize X-Real-IP.
- Changed X-Forwarded-For parsing to use the last IP in the list.
- Added comprehensive unit tests in src/lib/ip.test.ts.
- Updated API route to use the new utility.

Co-authored-by: instax-dutta <54683866+instax-dutta@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Mar 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
binify Ready Ready Preview, Comment Mar 14, 2026 5:04pm

@coderabbitai

coderabbitai Bot commented Mar 14, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@instax-dutta has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 47 seconds before requesting another review.

βŒ› How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 262e09ac-d0d8-4ee1-8e99-9a8d8d2ffdd5

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 6c75fd8 and 72c5363.

πŸ“’ Files selected for processing (4)
  • src/app/api/paste/route.ts
  • src/lib/ip.test.ts
  • src/lib/ip.ts
  • src/lib/validation.ts
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch security-fix-ip-spoofing-8564156710181733307
πŸ“ Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant