Open
Conversation
Co-authored-by: shajoezhu <3692541+shajoezhu@users.noreply.github.com>
Co-authored-by: shajoezhu <3692541+shajoezhu@users.noreply.github.com>
…gits Co-authored-by: shajoezhu <3692541+shajoezhu@users.noreply.github.com>
Co-authored-by: shajoezhu <3692541+shajoezhu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Expose digits argument for h_tbl_median_surv function
Expose digits argument for h_tbl_median_surv
Feb 12, 2026
Contributor
Unit Tests Summary 1 files 85 suites 1m 37s ⏱️ Results for commit 344bf69. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit 8e41787 ♻️ This comment has been updated with latest results. |
donyunardi
requested changes
Feb 13, 2026
donyunardi
left a comment
There was a problem hiding this comment.
Hi @shajoezhu
- Should the digit be exposed all the way to the top to
g_km? This is the function that's ultimately being used fortm_g_km - there's no request to address
h_km. This seems to be out-of-scope from the intended issue. Or is there any relationship betweeng_kmandh_km? - CI/CD did not pass, usually we make sure it passed before review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The
h_tbl_median_surv()function hardcodedsignif(..., 4)for rounding median survival estimates. Users can now control precision via adigitsparameter.Changes
h_tbl_median_surv(): Addeddigitsparameter (default: 4) to controlsignif()precision for median and CI valuescontrol_surv_med_annot(): Addeddigitsparameter to expose setting via control interfaceg_km(): Passesdigitsfromcontrol_annot_surv_medwith%||% 4fallback for backward compatibilityUsage
Backward compatible: default value and fallback maintain existing behavior.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.