251 deleayed datasets@main#252
Closed
chlebowa wants to merge 17 commits intoinsightsengineering:mainfrom
Closed
Conversation
663eb4c to
0fa6430
Compare
0fa6430 to
6616eab
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251
Added function
delayed_datasets. Use it to specifydatanameindata_extract_specto obtain adelayed_data_dextract_specthat will be turned into a number ofddesafter confronting actual data.Moved entire UI logic of
data_extract_moduleto arenderUIcall in the server function. Argumentslabelandis_single_data_extractare passed to the server function by creating invisible inputs and putting the argument values into them. The argumentdata_extract_specis now unused. The samedesis passed to the server function so all operations on it can be done in the server function without issue.The argument
data_extract_speccould now be removed from the ui function but that would require changes in all modules so I left it in.Addded function
assert_delayed_datasetsthat checks thatdelayed_datasetsare used properly when buildingdata_extract_specs.