Open
Conversation
I've suggested "code verified/unverified" because: 1. It's concise and clear 2. It focuses on what's actually being verified (the code that created the data) 3. It removes the redundant "teal_data object" since this is already known from the context
averissimo
requested changes
Jun 4, 2025
Contributor
averissimo
left a comment
averissimo
left a comment
There was a problem hiding this comment.
One typo on the documentation and 2 minor comments
| #' join_keys(data)data | ||
| #' | ||
| #' @export | ||
| append_join_keys <- function(x, values, after = length(join_keys(x))) { |
Contributor
There was a problem hiding this comment.
Do we need the after argument?
IIRC it has no practical effect (all join keys list elements are named and referenced as such).
Contributor
Author
There was a problem hiding this comment.
@averissimo so maybe we can change the name to add_join_keys
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.