Fix roxygen2 issue with all/all.equal ambiguity

[MichaelChirico]

You are affected by r-lib/roxygen2#1587. Came across your package while looking for a solution, so sharing what I found.

[github-actions]

✅ All contributors have signed the CLA
_{Posted by the CLA Assistant Lite bot.}

[MichaelChirico]

I have read the CLA Document and I hereby sign the CLA

[MichaelChirico]

recheck

[averissimo]

Thanks for the PR

I don't think this roxygen2 issue affects this package as the all.equal method is only meant to be available during tests.

We achieve that by registering the S3 method in a {testthat} helper.

teal.data/tests/testthat/helper-all.equal.R

Lines 2 to 4 in b5ccb1d

	if (testthat::is_testing()) {
	registerS3method("all.equal", "join_keys", all.equal.join_keys)
	}

@gogonzo do you want to revisit the export of this method?

Initially, we were hoping waldo would merge r-lib/waldo#186 as well as moving to {testthat} v3, but given that PR is almost 1 year old that seems unlikely.

[gogonzo]

I don't think either that this affects us.

[MichaelChirico]

to clarify I'm referring specifically to this:

teal.data/man/all.equal.join_keys.Rd

Line 7 in b5ccb1d

\method{all}{equal.join_keys}(target, current, ...)

[llrs-roche]

From previous experience registering the right S3 method helps with the dispatch, even if it is not exported (no exportMethods(all) or exportMethods(all.equal)) it must be registered to work well. I'm not familiar enough with join_keys and join_key_set but it is important on this context.

I also consider this very minimal (see the last commit) and without issues on a local check.

[m7pr]

r-lib/waldo#186 got merged