Lab3 submission#1028
Open
tdzdslippen wants to merge 8 commits into
Open
Conversation
Signed-off-by: tdzdslippen <avlaptev@avito.ru>
Signed-off-by: tdzdslippen <avlaptev@avito.ru>
Signed-off-by: tdzdslippen <avlaptev@avito.ru>
…o root Signed-off-by: tdzdslippen <avlaptev@avito.ru>
…tion Signed-off-by: tdzdslippen <avlaptev@avito.ru>
…b spec Signed-off-by: tdzdslippen <avlaptev@avito.ru>
Signed-off-by: tdzdslippen <avlaptev@avito.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Complete Lab 3 — a PR-gated CI pipeline for QuickNotes on GitHub Actions (vet + test + lint), made fast with caching, a Go-version matrix, and path filters.
Changes
.github/workflows/ci.yml— the pipeline:vet,test(go test -race -count=1),lint(golangci-lintpinned v2.5.0); each fails the PR independently.ubuntu-24.04everywhere (no:latest).checkoutv4.2.2,setup-gov5.6.0,golangci-lint-actionv8.0.0),permissions: contents: read(least privilege).setup-gobuild/module cache keyed ongo.mod(nogo.sum— std-lib only);strategy.matrixover Go 1.23 + 1.24 withfail-fast: false;paths:filter so docs-only PRs don't run CI.ci-gateaggregate job → a single stable required status check for branch protection.submissions/lab3.md— full write-up: requirements mapping, real run links + timings, the deliberate-failure/fix evidence, branch-protection screenshots (§1.7), and written answers to all 8 design questions (a–h) + bonus bottleneck analysis.submissions/branch-protection-*.png— branch-protection rule onmain(required checkci-gate).Testing
TestHealth_ReportsCount, commit2e38db9): bothtestlegs +ci-gatered → PR cannot merge: https://github.com/tdzdslippen/DevOps-Intro/actions/runs/27506990278bf66572): https://github.com/tdzdslippen/DevOps-Intro/actions/runs/27507029572mainrequiresci-gate; a--force-with-leasetomainwas rejected withprotected branch hook declined.Checklist
git log --show-signature)submissions/labN.mdupdated