Tutorial step 2 - Uplift to latest ink! and Openbrush#14
Open
bobo-k2 wants to merge 4 commits intotutorial/mint-step2from
Open
Tutorial step 2 - Uplift to latest ink! and Openbrush#14bobo-k2 wants to merge 4 commits intotutorial/mint-step2from
bobo-k2 wants to merge 4 commits intotutorial/mint-step2from
Conversation
bobo-k2
changed the title
Maar-io
approved these changes
Jul 31, 2023
Comment on lines
+21
to
25
| #[overrider(PSP34Mintable)] | ||
| #[openbrush::modifiers(only_owner)] | ||
| fn mint(&mut self, account: AccountId, id: Id) -> Result<(), PSP34Error> { | ||
| psp34::InternalImpl::_mint_to(self, account, id) | ||
| } |
Member
There was a problem hiding this comment.
This code is not needed since we added mint() in the contract implementation.
However if OB can now support payable in the overriden function then mint is not needed in the contract implementation
| instance._init_with_owner(instance.env().caller()); | ||
| let collection_id = instance.collection_id(); | ||
| instance._set_attribute( | ||
| let mut _instance = Self::default(); |
Member
There was a problem hiding this comment.
do not use _ since the variable is used
| "openbrush/std", | ||
| ] | ||
| ink-as-dependency = [] | ||
| ink-as-dependency = [] No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.