Refactoring #3
Draft
Refactoring #3
+3,609
−2,444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some code-smell cleanup Strong typing (got to .ts in the end...) Merging some 2-line files and 1-file directories...
aastefanov
commented
Dec 19, 2025
Don't reroute based on hardcoded roles or variants This actually checked which design was used before... + fix the package.json mishap
- cleanup the isVisible/isCurrent for the dashboard - simplify the grafana dashboard iframes
- reduce button sizes a bit - put two devices (doors/hvac/lights/...) on a single row
Note -- this may be reverted if it looks bad...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Гранде зачистване...