#2 Separate out WSAPI endpoints for INSERT and DELETE#4
Merged
MikeTaylor merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
clever by half. It modeled CCMS's INSERT and DELETE commands as a
single operation, POST to `/cyclops/sets/{setName}`, and invited you
to post an object containing parameters including `op` which could be
"add" or "remove". It would have required a `permissionsDesired` check
dependent on the operation.
Much better to let Okapi handle all that. I have redone the module
descriptor, the RAML, the schemas and the sample data to provide two
separate endpoints:
/cyclops/sets/{setName}/add
/cyclops/sets/{setName}/remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original WSAPI design for inserting and deleting records was too clever by half. It modeled CCMS's INSERT and DELETE commands as a single operation, POST to
/cyclops/sets/{setName}, and invited you to post an object containing parameters includingopwhich could be "add" or "remove". It would have required apermissionsDesiredcheck dependent on the operation.Much better to let Okapi handle all that. I have redone the module descriptor, the RAML, the schemas and the sample data to provide two separate endpoints:
/cyclops/sets/{setName}/add/cyclops/sets/{setName}/remove