Skip to content

Comments

Miguel why join sss#33

Open
migueljbeltran wants to merge 4 commits intomainfrom
miguel-why-join-sss
Open

Miguel why join sss#33
migueljbeltran wants to merge 4 commits intomainfrom
miguel-why-join-sss

Conversation

@migueljbeltran
Copy link
Collaborator

Description

Added why join sss component in home page for testing. also fixed the star overlay effect. made it so it fills the whole width of screen.

Closes #9

image

Checklist:

after creating your PR please mark all of these:

  • Global colors were used (let us know if any are missing)
  • Text/images/paths are not hard coded (passed in by props)

added to home for testing, used next image tag, some rem proportions were weird and wasn't filling the viewport, so i changed it to fit the screen. images i downloaded from figma has some compression issues i think.
@migueljbeltran migueljbeltran linked an issue Feb 17, 2026 that may be closed by this pull request
@migueljbeltran migueljbeltran self-assigned this Feb 17, 2026
Copy link
Collaborator

@austin1im austin1im left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one small thing! also could you move this to /test page you might need to create it

.section {
position: relative;
display: flex;
width: 100%;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this width 100% is necessary


.heading {
align-self: stretch;
color: #FFF;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know on the design its FFF but can you use var(--off-white) and can you do this for the rest of the texts too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why join SSS?

2 participants